-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbolic (symmetric-toepltiz)matrix-vector multiplication doesn't work for higher dimensions of matrix #939
Comments
It seems the multiplication is switching to FFT algorithm for large convolutions. I'm not sure what we can do about that. What's your goal with this? We could potentially make |
I fully support this idea, there's a lot of simplification you can do in Fourier space |
A lot of pseudospectral PDE codes could be nicely represented with it. I think more generally the question is how to register array functions. If registration works well on that, we can start getting coverage. |
Definitely agree on this point, I've run up against this a few times. Could just get the registration methods to wrap on |
@shashi My aim was to create that But it would be great if making fft a primitive in Symbolics could solve this issue. Certainly the said matrix-vector product is possible and user should be allowed to create them! What looks overall from error trace is that plan_fft! method entertaining Vector{Num} should be included somewhere. |
Array registration is a top priority for me right now. @yewalenikhil65 even if we support |
Yeah I think that's all you need. Once that exists, the community can register a whole standard library etc. and take it from there. But without that registration, these kinds of issues will just pop up. You don't need to worry about an |
This probably needs a broad request to package maintainers to register important functions in package |
I am trying following , and this works okay!
However, the code fails if i increase the code to N=280
The text was updated successfully, but these errors were encountered: