Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The great symbolics update #819

Closed
2 of 22 tasks
ChrisRackauckas opened this issue Jan 14, 2023 · 17 comments
Closed
2 of 22 tasks

The great symbolics update #819

ChrisRackauckas opened this issue Jan 14, 2023 · 17 comments
Assignees

Comments

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jan 14, 2023

Let's handle as much of this as possible this next week.

@anandijain @ArnoStrouwen

@isaacsas
Copy link
Contributor

I guess this applies to Catalyst too? Not sure why we didn’t get a compat helper bump there.

@ChrisRackauckas
Copy link
Member Author

Maybe CompatHelper's last night run there failed too. Yeah I just generated this list from my email so it's maybe not all of them.

@ArnoStrouwen
Copy link
Contributor

All the CompatHelper PRs already here run every hour, while Catalyst runs once a day. It will probably come later, together with the other repos that run daily.

@xtalax
Copy link
Contributor

xtalax commented Jan 16, 2023

Merged in MethodOfLines.jl

@ArnoStrouwen
Copy link
Contributor

ArnoStrouwen commented Jan 16, 2023

Merged in MethodOfLines.jl

MOL depends on MTK though, which is not yet updated.

@xtalax
Copy link
Contributor

xtalax commented Jan 17, 2023

Yes, leaving this unreleased for now

@ArnoStrouwen
Copy link
Contributor

ArnoStrouwen commented Feb 9, 2023

Some notes to keep track of which packages are best to start with

SymbolicNumericIntegration requires DataDrivenDiffEq to be compatible with new Symbolics
DataDrivenDiffEq requires SymbolicRegression to be compatible with new Symbolics
SymbolicRegression requires DynamicExpressions to be compatible with new Symbolics
DynamicExpressions is currently blocked by JuliaSymbolics/SymbolicUtils.jl#500

CellMLToolkit requires MathML to be compatible with new Symbolics
SBMLToolkit requires MathML and Catalyst to be compatible with new Symbolics

DiffEqDocs requires Catalyst to be compatible with new Symbolics
ReactionNetworkImporters requires Catalyst to be compatible with new Symbolics

SciMLBenchmarks/StiffODE requires a bunch of things to be changed

@ArnoStrouwen
Copy link
Contributor

This page seems out of date: https://juliasymbolics.org/

@ChrisRackauckas
Copy link
Member Author

MathML is done

@xtalax
Copy link
Contributor

xtalax commented Feb 13, 2023

I take it that the following is related?

(PDESystemLibrary) pkg> add NeuralPDE
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package NeuralPDE [315f7962]:
 NeuralPDE [315f7962] log:
 ├─possible versions are: 2.0.0-5.3.0 or uninstalled
 ├─restricted to versions * by an explicit requirement, leaving only versions 2.0.0-5.3.0
 ├─restricted by compatibility requirements with SymbolicUtils [d1185830] to versions: 2.0.0-3.15.0 or uninstalled, leaving only versions: 2.0.0-3.15.0
 │ └─SymbolicUtils [d1185830] log:
 │   ├─possible versions are: 0.1.0-1.0.3 or uninstalled
 │   ├─restricted to versions 1 by ModelingToolkit [961ee093], leaving only versions 1.0.0-1.0.3
 │   │ └─ModelingToolkit [961ee093] log:
 │   │   ├─possible versions are: 8.47.0 or uninstalled
 │   │   └─ModelingToolkit [961ee093] is fixed to version 8.47.0
 │   └─restricted by compatibility requirements with Symbolics [0c5d862f] to versions: 1.0.1-1.0.3
 │     └─Symbolics [0c5d862f] log:
 │       ├─possible versions are: 0.1.0-5.0.2 or uninstalled
 │       └─restricted to versions 5 by ModelingToolkit [961ee093], leaving only versions 5.0.0-5.0.2
 │         └─ModelingToolkit [961ee093] log: see above
 ├─restricted by compatibility requirements with RuntimeGeneratedFunctions [7e49a35a] to versions: [2.0.0-2.7.0, 3.3.0-5.3.0] or uninstalled, leaving only versions: [2.0.0-2.7.0, 3.3.0-3.15.0]
 │ └─RuntimeGeneratedFunctions [7e49a35a] log:
 │   ├─possible versions are: 0.1.0-0.5.5 or uninstalled
 │   └─restricted to versions 0.4.3-0.5 by ModelingToolkit [961ee093], leaving only versions 0.5.0-0.5.5
 │     └─ModelingToolkit [961ee093] log: see above
 └─restricted by compatibility requirements with ModelingToolkit [961ee093] to versions: 4.2.0-5.3.0 or uninstalled — no versions left
   └─ModelingToolkit [961ee093] log: see above

@ArnoStrouwen
Copy link
Contributor

ModelingToolkit [961ee093] is fixed to version 8.47.0

If MTK is fixed to the latest release, which is only compatible with the latest Symbolics, then it won't be compatible with NeuralPDE since that is still on old Symbolics.

@xtalax
Copy link
Contributor

xtalax commented Feb 13, 2023

@ArnoStrouwen Do you know how complex updating NeuralPDE to 5.0 is? I may try this.

@ArnoStrouwen
Copy link
Contributor

@xtalax There currently are no more blockers, i.e. other packages that need to be updated before NeuralPDE can be updated.
I tried forcing the new versions here: ArnoStrouwen/NeuralPDE.jl#3 and this fails.
I don't know more than that.

@MilesCranmer
Copy link

DynamicExpressions.jl (>=0.5.1) and SymbolicRegression.jl (>=0.16.3) have just been updated to SymbolicUtils.jl v1! Thanks to @shashi for fixing an issue with LiteralReal 🥳

@xtalax
Copy link
Contributor

xtalax commented Apr 13, 2023

Neural is done :)

@ArnoStrouwen
Copy link
Contributor

Is there anything of this that is still open?
All the stuff in my above comments seems to have been done.

@ChrisRackauckas
Copy link
Member Author

Yup we're past this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants