Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Potential graphs and way to make them #29

Closed
lrnv opened this issue Apr 25, 2024 · 2 comments
Closed

[Discussion] Potential graphs and way to make them #29

lrnv opened this issue Apr 25, 2024 · 2 comments

Comments

@lrnv
Copy link
Member

lrnv commented Apr 25, 2024

@rimhajal I think the easiest way to decide if we really need to include graphing code into our package is first to design graphs in the documentation.

So the right path would be as follows (IMHO):

  • Write up as documentation pages long examples following 1) Maja's practice, 2) Maya's paper 3) some other source we have like Nathalie's slides ?
  • Alongside this documentation, when something needs to be plotted, do it with Plots.jl's standard interface (you should probably read a bit their documentation)
  • When this is done, if some graphs really were complicated to make, we'll consider adding some special syntax for them in the package. If all the graphs are "easy" to make, then having them in the docs alongside the code that produces them will be largely enough.

Tell me what you think

@lrnv lrnv mentioned this issue Apr 25, 2024
33 tasks
@lrnv lrnv changed the title Graphs that matches 1) Maya's paper 2) maja's practice [Dicussion] Potential graphs and way to make them Apr 25, 2024
@rimhajal
Copy link
Member

That sounds good ! Because I believe the syntax isn't too complicated. Maybe towards the end if we have time we can customize something :)

@lrnv
Copy link
Member Author

lrnv commented May 2, 2024

@rimhajal So i guess that after what you did on the examples, there is no real need to include graphing code into the package, right ? If so, then we can simply close this issue and check/remove the corresponding boxes in the general todolist.

@lrnv lrnv changed the title [Dicussion] Potential graphs and way to make them [Discussion] Potential graphs and way to make them May 2, 2024
@rimhajal rimhajal closed this as completed May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants