Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method ambiguities reported by Aqua #71

Closed
prbzrg opened this issue Dec 27, 2023 · 3 comments
Closed

Method ambiguities reported by Aqua #71

prbzrg opened this issue Dec 27, 2023 · 3 comments

Comments

@prbzrg
Copy link

prbzrg commented Dec 27, 2023

In Julia v1.10, I used Aqua to detect method ambiguities in my package impICNF/ContinuousNormalizingFlows.jl#356 and some of its report were related to this package:

Ambiguity #74
defalg(::AbstractArray{<:Union{Missing, InlineStrings.String1, InlineStrings.String15, InlineStrings.String3, InlineStrings.String7}}) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:942
defalg(v::AbstractArray{<:Union{Missing, Number}}) @ Base.Sort sort.jl:1350

Possible fix, define
  defalg(::AbstractArray{<:Missing})

Ambiguity #83
lstrip(f, s::InlineStrings.InlineString) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:482
lstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:372

Possible fix, define
  lstrip(::AbstractString, ::InlineStrings.InlineString)

Ambiguity #84
lstrip(f, s::InlineStrings.String1) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:481
lstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:372

Possible fix, define
  lstrip(::AbstractString, ::InlineStrings.String1)

Ambiguity #101
rstrip(f, s::InlineStrings.InlineString) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:525
rstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:406

Possible fix, define
  rstrip(::AbstractString, ::InlineStrings.InlineString)

Ambiguity #102
rstrip(f, s::InlineStrings.String1) @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:524
rstrip(::AbstractString, ::AbstractString) @ Base strings/util.jl:406

Possible fix, define
  rstrip(::AbstractString, ::InlineStrings.String1)

Ambiguity #113
unsafe_convert(::Type{Ptr{Int8}}, x::Ref{T}) where T<:InlineString @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:169
unsafe_convert(::Type{P}, x::Ptr) where P<:Ptr @ Base essentials.jl:543

Possible fix, define
  unsafe_convert(::Type{Ptr{Int8}}, ::Ptr{T}) where T<:InlineStrings.InlineString

Ambiguity #114
unsafe_convert(::Type{Ptr{UInt8}}, x::Ref{T}) where T<:InlineString @ InlineStrings ~/.julia/packages/InlineStrings/rlLZO/src/InlineStrings.jl:167
unsafe_convert(::Type{P}, x::Ptr) where P<:Ptr @ Base essentials.jl:543

Possible fix, define
  unsafe_convert(::Type{Ptr{UInt8}}, ::Ptr{T}) where T<:InlineStrings.InlineString

I would appreciate your attention to this issue.

@prbzrg
Copy link
Author

prbzrg commented Dec 27, 2023

Related to #64

@ufechner7
Copy link

Can this be fixed in this package?

@KristofferC
Copy link
Member

Let's "merge" this into #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants