Skip to content

No Formula struct #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ajinkya-k opened this issue Mar 17, 2025 · 3 comments · May be fixed by #322
Open

No Formula struct #321

ajinkya-k opened this issue Mar 17, 2025 · 3 comments · May be fixed by #322

Comments

@ajinkya-k
Copy link

the documentation for @formula macro refers to the Formula struct, but as far as I can tell there is no such struct defined. See here:

StatsModels.jl/src/formula.jl

Line 26 in e029ef4

Capture and parse a formula expression as a `Formula` struct.

Was this supposed to be changed to FormulaTerm at some point of time? Because currently the @formula macro returns a FormulaTerm struct. I am happy to make changes to the docstrings for this
@kleinschmidt
Copy link
Member

Yes that's out of date, a PR would be very welcome!

@ajinkya-k ajinkya-k linked a pull request Mar 18, 2025 that will close this issue
Open
@ajinkya-k
Copy link
Author

ajinkya-k commented Mar 18, 2025 •
edited
Loading

Yes that's out of date, a PR would be very welcome!

Done!

@ajinkya-k
Copy link
Author

ajinkya-k commented Mar 18, 2025 •
edited
Loading

@kleinschmidt Can you check if the changes are correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changed Formula to FormulaTerm in documentation and docstrings, fixes #321 ajinkya-k/StatsModels.jl
2 participants
@kleinschmidt @ajinkya-k