Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov: set fail_ci_if_error to false iff the PR is made from a fork #920

Closed
wants to merge 3 commits into from
Closed

Codecov: set fail_ci_if_error to false iff the PR is made from a fork #920

wants to merge 3 commits into from

Conversation

DilumAluthge
Copy link
Contributor

No description provided.

@DilumAluthge DilumAluthge marked this pull request as ready for review March 8, 2024 12:02
@DilumAluthge
Copy link
Contributor Author

@devmotion What do you think of this approach?

@devmotion
Copy link
Member

I think this might be useful given the current instability of codecov. I'd like to avoid surprising coverage drops in PRs from forks though - maybe if someone with admin permission additionally makes codecov a mandatory check, this would not be possible? On the other hand, of course, this would require that at least one of the codecov uploads succeeds.

@DilumAluthge
Copy link
Contributor Author

You could set up GitHub Merge Queue on this repo, and then make Codecov a required status check. The GitHub Merge Queue jobs (merge_group jobs) will have access to the CODECOV_TOKEN.

@andreasnoack
Copy link
Member

Hasn't the Codecov action stabilized so much at this point that it's not worth adding extra complexity to our script?

@DilumAluthge DilumAluthge deleted the dpa/codecov-allow-fail-fork-prs branch June 21, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants