Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design question/discussion: PDMat without constructing full matrix #140

Open
st-- opened this issue Oct 27, 2021 · 1 comment
Open

Design question/discussion: PDMat without constructing full matrix #140

st-- opened this issue Oct 27, 2021 · 1 comment

Comments

@st--
Copy link
Contributor

st-- commented Oct 27, 2021

As pointed out in the README, PDMat always stores both Cholesky factorisation and full matrix. For many operations that are commonly used downstream, such as logdet and the quadratic forms, the full matrix is never used. So when the PDMat is constructed from an already known Cholesky factor (e.g. because we optimize for a variationally optimal covariance matrix), this is an unnecessary computation (see JuliaGaussianProcesses/ParameterHandling.jl#41 (comment)).

What are the design reasons for the current setup? What would it take to change this? Could we, for example, have some lazy way of computing mat (or chol) only when it is actually required [and then caching it]?

@st-- st-- changed the title PDMat without constructing full matrix Design question/discussion: PDMat without constructing full matrix Oct 28, 2021
@st--
Copy link
Contributor Author

st-- commented Mar 31, 2022

What are the PDMats.jl maintainers' thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant