diff --git a/src/sparsematrix.jl b/src/sparsematrix.jl index f123a270..76d8023e 100644 --- a/src/sparsematrix.jl +++ b/src/sparsematrix.jl @@ -191,7 +191,7 @@ const SparseMatrixCSCUnion2{Tv,Ti} = Union{AbstractSparseMatrixCSC{Tv,Ti}, Spars getcolptr(S::SorF) = getfield(S, :colptr) getcolptr(S::SparseMatrixCSCView) = view(getcolptr(parent(S)), first(S.indices[2]):(last(S.indices[2]) + 1)) -getcolptr(S::SparseMatrixCSCView2) = error("just to make sure") +getcolptr(S::SparseMatrixCSCView2) = error("getcolptr not well-defined for $(typeof(S))") getrowval(S::AbstractSparseMatrixCSC) = rowvals(S) getrowval(S::SparseMatrixCSCView2) = rowvals(parent(S)) getnzval( S::AbstractSparseMatrixCSC) = nonzeros(S) diff --git a/test/linalg.jl b/test/linalg.jl index d1825a82..19028877 100644 --- a/test/linalg.jl +++ b/test/linalg.jl @@ -152,6 +152,7 @@ begin A = sprand(rng, n, n, 0.01) MA = Matrix(A) lA = sprand(rng, n, n+10, 0.01) + @test nnz(lA[:, n+1:n+10]) == nnz(view(lA, :, n+1:n+10)) @testset "triangular multiply with $tr($wr)" for tr in (identity, adjoint, transpose), wr in (UpperTriangular, LowerTriangular, UnitUpperTriangular, UnitLowerTriangular) AW = tr(wr(A))