Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make directions return unit-vectors #66

Closed
3 tasks done
MicheleCeresoli opened this issue Aug 2, 2024 · 1 comment
Closed
3 tasks done

Make directions return unit-vectors #66

MicheleCeresoli opened this issue Aug 2, 2024 · 1 comment
Assignees
@andreapasquale94 @MicheleCeresoli
Labels
feature New feature or request

Comments

@MicheleCeresoli
Copy link
Member

MicheleCeresoli commented Aug 2, 2024 •
edited by andreapasquale94
Loading

All direction functions should return unit-vectors as agreed in #65:

  • The existing functions should implement normalisation.
  • add_direction_normalize should be removed.
  • The users should be informed that their custom-made direction functions should return unit-vectors.
@MicheleCeresoli MicheleCeresoli added the feature New feature or request label Aug 2, 2024
@andreapasquale94
Copy link
Member

Done in v3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreapasquale94 andreapasquale94

@MicheleCeresoli MicheleCeresoli

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreapasquale94 @MicheleCeresoli