Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Zygote Extension #28

Merged
merged 32 commits into from
Feb 15, 2025
Merged

Conversation

jmurphy6895
Copy link
Contributor

Added Zygote Extension and made small typing changes to handle autodiff workflows through DCM calls in SatelliteToolboxTransformations. This PR does not cover the entire package only the DCM functions called in SatelliteToolboxTransformations.

@jmurphy6895
Copy link
Contributor Author

Sorry about all of the commits, Zygote was being very finicky and testing here and in SatelliteToolboxTransformations took a bit of experimentation to get everything working

@ronisbr
Copy link
Member

ronisbr commented Jan 31, 2025

Hi @jmurphy6895 !

I am getting very strange errors with this commit in our private code base. However, I have a felling that those problems are not related. As soon as I manage to confirm this, I merge this PR.

@ronisbr
Copy link
Member

ronisbr commented Feb 15, 2025

Thanks @jmurphy6895 !

@ronisbr ronisbr merged commit 27de6e5 into JuliaSpace:master Feb 15, 2025
@ronisbr
Copy link
Member

ronisbr commented Feb 15, 2025

Hi @jmurphy6895 !

For some reason, the tests are failing in nightly. Can you please check?

@ronisbr
Copy link
Member

ronisbr commented Feb 15, 2025

It's a know bug:

JuliaLang/julia#57417

@jmurphy6895
Copy link
Contributor Author

Hey @ronisbr! Yeah I'll look at the linked issue and see if I can resolve this in the next couple days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants