Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace σ by 1/α #255

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

d-monnet
Copy link
Contributor

This is needed for further uniformization with TR based on linear model and including momentum strategy.

@d-monnet d-monnet requested a review from tmigot February 18, 2024 20:50
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5c08163) 88.48% compared to head (cc99082) 88.48%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/R2.jl 66.66% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   88.48%   88.48%           
=======================================
  Files           7        7           
  Lines        1025     1025           
=======================================
  Hits          907      907           
  Misses        118      118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Package name latest stable
FletcherPenaltySolver.jl
Percival.jl

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @d-monnet

@tmigot tmigot merged commit 91deabd into JuliaSmoothOptimizers:main Feb 18, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants