Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative predicted reduction in tron/trunk #266

Closed
tcovert opened this issue Mar 28, 2024 · 3 comments
Closed

Negative predicted reduction in tron/trunk #266

tcovert opened this issue Mar 28, 2024 · 3 comments

Comments

@tcovert
Copy link

tcovert commented Mar 28, 2024

Hi JSO team,

What should I infer about my problem and/or its suitability for use with tron/trunk if I encounter solution status equal to :neg_pred?

The problem I am solving is unconstrained, and is definitely not globally convex (I am trying to minimize the negative log likelihood of a nested logit model). lbfgs does seem to "work" in the sense that if I give it a reasonable amount of time, it finds a reasonable fit (though I've yet to run it long enough to see if it converges). Is the failure mode I am encountering with tron and trunk telling me something about the structure of my problem? That I have perhaps a bug in my log-likelihood definition? Or something else?

When I solve a simpler non-convex problem using similar data ("vanilla" logit, but with scale parameters that vary across choice sets, this heterogeneity I believe makes the problem non-convex), both tron and trunk seem to work great. So I'm scratching my head about my nested logit setup...

Thanks in advance for any advice you might have.

@tcovert tcovert changed the title Negative predicted directions in tron/trunk Negative predicted reduction in tron/trunk Mar 28, 2024
@tcovert
Copy link
Author

tcovert commented Mar 28, 2024

If it helps, I'm using autodiff (Zygote for gradients, and ForwardDiff over Zygote for the hessian-vector product).

@tmigot
Copy link
Member

tmigot commented Mar 28, 2024

Hi @tcovert ! Thanks for the issue
Is there any chance you have a reproducible example?

@tcovert
Copy link
Author

tcovert commented Apr 4, 2024

Sorry, I realized this was a bug in my autodiff implementation (I had written an incorrect custom adjoint), not an issue with the solver. My bad.

@tcovert tcovert closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants