-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references for R2 and LBFGS in readme #236 #259
Conversation
Added References to LBFGS and R2.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 7 7
Lines 1025 1025
=======================================
Hits 907 907
Misses 118 118 ☔ View full report in Codecov by Sentry. |
As far as I know, there's no reference for R2 itself. I'm not sure our paper with D. Orban is the most relevant reference, I'll let @dpo decide what reference is the most appropriate. |
Added suggested citations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just a minor final comment.
Indentations fixed.
Co-authored-by: Dominique <[email protected]>
Commited dpo sugesstions Co-authored-by: Dominique <[email protected]>
Thank you! |
This pull request addresses issue #236 by adding references for the R2 and LBFGS implementations in the project's readme.
Changes Made:
Related Issue:
Closes #236