Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRON: add a warning if initial guess is not within the bounds #244

Closed
tmigot opened this issue Oct 5, 2023 · 3 comments · Fixed by #246
Closed

TRON: add a warning if initial guess is not within the bounds #244

tmigot opened this issue Oct 5, 2023 · 3 comments · Fixed by #246
Labels
good first issue Good for newcomers

Comments

@tmigot
Copy link
Member

tmigot commented Oct 5, 2023

I noticed we don't projet the initial guess, so if verbose>0 we should probably send some warning

@tmigot tmigot added the good first issue Good for newcomers label Oct 5, 2023
@Jay-sanjay
Copy link
Contributor

Jay-sanjay commented Nov 20, 2023

@tmigot sir is it fine if, I add this condition in tronls.jl , tron.jl , trunk.jl , trunkls.jl , R2.jl , lbfgs.jl ,
if verbose > 0
error("Invalid input")
end

@tmigot
Copy link
Member Author

tmigot commented Nov 21, 2023

Thanks for thé suggestion @Jay-sanjay
I think it should be a warning not an error and it only concerns TRON and TRON-NLS as they are the only handling bounds.

The warning message could be : Initial guess is not within bounds.

@dpo
Copy link
Member

dpo commented Nov 21, 2023

Also, the projection should happen.

@Jay-sanjay Jay-sanjay mentioned this issue Nov 22, 2023
2 tasks
@tmigot tmigot linked a pull request Dec 18, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants