local_loss should call increment obj

[tmigot]

FluxNLPModels.jl/src/utils.jl

Line 11 in d2cf7b9

function local_loss(nlp::AbstractFluxNLPModel{T, S}, x, y, w::AbstractVector{T}) where {T, S}

or have some specific counters.

[farhadrclass]

@tmigot would it be possible to explain more

[tmigot]

It felt like this function is actually evaluating the objective function, and is sometimes called without update of counters

[farhadrclass]

I agree,
Also in objgrad!, can we improve this?

 x, y = nlp.current_training_minibatch
  f_w = nlp.loss_f(nlp.chain(x), y)
  g .= gradient(w_g -> local_loss(nlp, x, y, w_g), w)[1]