-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream and then tar heap snapshot #48
Conversation
b5ebcda
to
e2a173c
Compare
d497f7b
to
7695c22
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
===========================================
- Coverage 90.00% 78.87% -11.13%
===========================================
Files 1 1
Lines 190 232 +42
===========================================
+ Hits 171 183 +12
- Misses 19 49 +30 ☔ View full report in Codecov by Sentry. |
7695c22
to
2bf8076
Compare
Bump? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ LGTM.
Is this already covered by a test? Can the test just confirm that the file path ends in .tar
or something like that?
(Sorry, I probably closed by accident) |
Thanks for the suggestion. Added a test to test the extension. |
To avoid building the heap snapshot in-memory and therefore possibly OOMing if the process is under memory pressure.