Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable -gz #7597

Open
vtjnash opened this issue Oct 30, 2023 · 3 comments
Open

enable -gz #7597

vtjnash opened this issue Oct 30, 2023 · 3 comments

Comments

@vtjnash
Copy link
Member

vtjnash commented Oct 30, 2023

It seems like this may shrink some things quite significantly, per JuliaLang/julia#45631 (also could enable zstd instead of zlib, which likely has better performance and compression ratios, but that option is more recent)

@imciner2
Copy link
Member

Does that only compress the debug sections? I think a lot of the binaries here are built without debug information (e.g. the default recommended CMake configuration is Release, same with Meson and Rust), so it might not actually make a large difference to the Ygg binaries.

@benlorenz
Copy link
Contributor

I think it would be good to get a zlib enabled LLVM into julia-1.6 before creating compressed debug sections in jlls (at least if they target 1.6 as well).

This is not really nice user experience, see JuliaLang/julia#47727:

 $ julia-1.6.7
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.6.7 (2022-07-19)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

julia> someerror
ERROR: error: failed to decompress '.debug_aranges', zlib is not available
error: failed to decompress '.debug_info', zlib is not available
error: failed to decompress '.debug_abbrev', zlib is not available
error: failed to decompress '.debug_line', zlib is not available
error: failed to decompress '.debug_str', zlib is not available
error: failed to decompress '.debug_line_str', zlib is not available
error: failed to decompress '.debug_loclists', zlib is not available
error: failed to decompress '.debug_rnglists', zlib is not available
UndefVarError: someerror not defined

(I have compressed debug sections in some system libraries)

@ViralBShah
Copy link
Member

I believe we do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants