Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-D causes infinite loop of line prompt #1227

Open
lucifer1004 opened this issue Sep 18, 2022 · 0 comments · May be fixed by #1228
Open

Ctrl-D causes infinite loop of line prompt #1227

lucifer1004 opened this issue Sep 18, 2022 · 0 comments · May be fixed by #1228
Labels
bug 🐛 wizard 🧙

Comments

@lucifer1004
Copy link

BinaryBuilder.jl/src/wizard/utils.jl

Lines 48 to 57 in f20e6d0

function nonempty_line_prompt(name, msg; outs=stdout, kwargs...)
while true
val = line_prompt(name, msg; outs=outs, kwargs...)
if isempty(val)
printstyled(outs, "$(name) may not be empty!\n", color=:red)
continue
end
return val
end
end

To reproduce:

  • Run the wizard
  • Go to step 2
  • When the prompt asks you to enter a URL, press Ctrl-D
  • Infinite loop starts
lucifer1004 added a commit to lucifer1004/BinaryBuilder.jl that referenced this issue Sep 18, 2022
@lucifer1004
fix: throw EOFError properly (JuliaPackaging#1227)
85ce496
@lucifer1004 lucifer1004 linked a pull request Sep 18, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 wizard 🧙
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Throw EOFError when encountering Ctrl-D lucifer1004/BinaryBuilder.jl
2 participants
@giordano @lucifer1004