-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also export gaverstehfest
as alias to postwilder
.
#24
Comments
Thanks for bringing attention to this because the method does have competing naming. In my field it is generally referred to as the "Post-Widder" formula whereas I have seen many instances where "Gaver-Stehfest" is preferred. I'm not for sure adding two methods for this would lead to less confusion. It might be easiest to do this on the user end if they prefer one name over the other by defining A name change would be fine and fairly easy if we think that [1] Post, Emil L. "Generalized differentiation." Transactions of the American Mathematical Society 32.4 (1930): 723-781. But yes, Stehfest proposed a discrete version of the Post-Widder formula which is what is being used. A name change may also avoid confusion with Post's formula mentioned in #10. |
Thanks for gathering the bibliography, I completely agree with your choices of citations. Some remarks:
I could argue more, but you already understood that I'm voting for a change of name to Edit : I completely agree that #10 is indeed what should be named "Post-Wilder". In other languages than Julia it might not be so clear, but here we have formal differentiations techniques that allows exploitation of these kind of 'theoretical' results directly, without discretisation. |
Thanks for your notes! I do agree, and would be happy to make these changes. I think some of the confusion lies maybe in this review paper [1] which mentions the Post-Widder formula under the Gaver-Stehfest method. The papers in my field cite this review article and refer to it as "Post-Widder" which I'm leaning towards perhaps being a mischaracterization :) In fact, it looks like the author is also the author of mpmaths Inverse laplace methods [2] which names it just [1] Kuhlman, Kristopher L. "Review of inverse Laplace transform algorithms for Laplace-space numerical approaches." Numerical Algorithms 63.2 (2013): 339-355. |
Wow, this is a bit confusing. To make it clear in this thread, the code for the algorithm in question was contributed by @heltonmc .
|
Thanks @jlapeyre ! I went ahead and made these changes and submitted #25. I've talked with a few other people on this and it seems like "Gaver-Stehfest" is the preferred name which is often how it is referred to in academic papers. I changed the name to This also frees up #10 to be named something like This is my mistake. Thank you everyone. |
Hi,
Would it be possible to also export a
gaverstehfest
method that would be an alias for the currentpostwilder
? I was looking for this algorithm and was about to start a fork to implement it because I did not saw it.In a large part of the literature, the name of this algorithm is 'Gaver-Stehfest', in the names of Gaver, who found the approximating series, and Stehfest, who found the accelerated convergence tricks. Post-Wilder are the ones that found the continuous formula that Gaver's work derives from.
Also, the principal cited source in
postwilder.jl
is written by Stehfest, not Post-Wilder.I do not ask for a change of name -- would probably be breaking --, an alias would be enough.
The text was updated successfully, but these errors were encountered: