Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move arithmetic definitions into a submodule FixedPointNumbers.FixedPointArithmetic #239

Open
kimikage opened this issue Dec 23, 2020 · 2 comments
Open

Move arithmetic definitions into a submodule FixedPointNumbers.FixedPointArithmetic #239

kimikage opened this issue Dec 23, 2020 · 2 comments
Labels
needs comments

Comments

@kimikage
Copy link
Collaborator

kimikage commented Dec 23, 2020 •
edited
Loading

cf. #142 (comment)

I will move the definitions of checked_*/saturating_*/wrapping_* to CheckedArithmeticCore.jl and add the implementation for integer types there. (cf. JuliaMath/CheckedArithmetic.jl#9)

In addition to @checked, @wrapping and @saturating macros will be provided by CheckedArithmetic.jl. Those macros should be available for FixedPoint as well.
@kimikage kimikage added this to the 0.9 milestone Dec 23, 2020
@kimikage kimikage mentioned this issue Dec 23, 2020
Open
@kimikage kimikage mentioned this issue Mar 25, 2021
Closed
@kimikage
Copy link
Collaborator Author

kimikage commented Apr 5, 2024 •
edited
Loading

Since we got the package extension mechanism, the new module should be something like FixedPointNumberCheckedArithmeticCoreExt.

@kimikage kimikage closed this as completed Apr 6, 2024
@kimikage kimikage removed this from the 0.9 milestone Apr 6, 2024
@kimikage kimikage reopened this Apr 30, 2024
@kimikage kimikage mentioned this issue Apr 30, 2024
Closed
@kimikage
Copy link
Collaborator Author

See: JuliaMath/OverflowContexts.jl#7

@kimikage kimikage changed the title Move arithmetic definitions/implementations into a submodule FixedPointNumbers.FixedPointArithmetic Move arithmetic definitions into a submodule FixedPointNumbers.FixedPointArithmetic May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[RFC] Move arithmetic functions into submodule FixedPointArithmetic kimikage/FixedPointNumbers.jl
1 participant
@kimikage