Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointless norm on vector fibers #209

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Pointless norm on vector fibers #209

merged 4 commits into from
Oct 24, 2024

Conversation

mateuszbaran
Copy link
Member

Implements the feature discussed here: JuliaManifolds/LieGroups.jl#8 (comment) .

@mateuszbaran mateuszbaran added enhancement New feature or request preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready labels Oct 21, 2024
@mateuszbaran
Copy link
Member Author

Oh, I'm not sure if we can have that:

norm(itr, p::Real) @ LinearAlgebra /opt/hostedtoolcache/julia/1.10.5/x64/share/julia/stdlib/v1.10/LinearAlgebra/src/generic.jl:595
norm(M::ManifoldsBase.VectorSpaceFiber{𝔽} where 𝔽, X) @ ManifoldsBase ~/work/ManifoldsBase.jl/ManifoldsBase.jl/src/VectorFiber.jl:11

Especially after #206 .

@mateuszbaran
Copy link
Member Author

My local testing indicates that it doesn't break anything in Manifolds.jl.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (5972cde) to head (8b9447a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          31       31           
  Lines        3398     3399    +1     
=======================================
+ Hits         3396     3397    +1     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NEWS.md Outdated Show resolved Hide resolved
Copy link
Member

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

± the small improvement that this is a bugfix actually, this all looks good.

Co-authored-by: Ronny Bergmann <[email protected]>
@mateuszbaran mateuszbaran merged commit 6094c5e into master Oct 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request preview docs Add this label if you want to see a PR-preview of the documentation Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants