-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce r-norms on manifolds with components #206
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 99.90% 99.94% +0.03%
==========================================
Files 31 31
Lines 3301 3398 +97
==========================================
+ Hits 3298 3396 +98
+ Misses 3 2 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments.
Co-authored-by: Mateusz Baran <[email protected]>
…ManifoldsBase.jl into kellertuer/product_norms
Co-authored-by: Mateusz Baran <[email protected]>
I rephrased the docs and made more clearer, that |
Thanks for already fixing all the types ( Let's postpone the idea |
Thanks! Let's not do recursive |
Can I merge this later today? I would like to maybe do the gradient change stopping criterion later today still, which was the origin for this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I just have a few minor comments.
Co-authored-by: Mateusz Baran <[email protected]>
For manifolds that consist of components, like product, power and default manifold, this introduces an additional parameter to distance to specify the outer norm to be used after computing the single components distances; this especially also covers the 1- and ∞-norm cases.
It also introduces a
has_components
function to be able to check whether a manifold can compute such an (outer) norm.🛣️🗺️
ProductManifold
PowerManifold
DefaultManifold
norm