-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the tutorial and move to quarto. #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
==========================================
- Coverage 99.92% 99.84% -0.08%
==========================================
Files 19 19
Lines 2538 2537 -1
==========================================
- Hits 2536 2533 -3
- Misses 2 4 +2
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
A future idea would be to do a tutorial for traits with an embedding idea, and maybe one for metrics or such. |
Hm, locally everything works, but the documenter CI says IJulia is missing the 1.9 kernel? Not yet sure why...the first set seems to be a bit difficult every now and then of quarto+Julia maybe. |
Hm, I am a bit lost here, all config files are exactly the same as for Manopt.jl and IJulia us built directly before we switch to quarto, still IJulia seems to not have Julia 1.9 in its kernels. To me a total mystery. |
…s not found though IJulia is complíled right before :/
Further investigations, directly before it says the kernel is not present it lists the kernel as present see the currently added warning at https://github.com/JuliaManifolds/ManifoldsBase.jl/actions/runs/5431263051/jobs/9877519967#step:9:709 |
Finally managed to set up the CI correctly. Now the only thing left is to find out why |
This is finished besides the discussion on the default difference between retract and exp |
Sure, I think this can use Quarto as well.
IIRC I wanted to make
Sure, that is a good idea. |
But can we fix that without breaking, that is having both work the same? This is not so urgent since it mainly affects people implementing manifolds, not using them, but it would be great to have a unified interface. For the Retraction types, I will add that to the docs then. |
I added a note to all retractions and inverse retractions which functions are related to them. I also moved the discussion about exp/retract to a new issue – and did a thorough check about the current state there. So this PR should be ready to go :) |
As far as I know, we can't. |
Well, then with breaking ;) Still unifying them would help users I think. |
I agree, we should unify them next time we make a breaking change here. |
Then let's find a good unification in the issue and do that before the next breaking change :) |
Ups, it seems I missed that |
Co-authored-by: Mateusz Baran <[email protected]>
THanks, since this does not introduce a new feature is it ok if we leave it on master until the next feature comes along? |
I think it's better to register since stable docs will then include this change. |
This PR simplifies the existing tutorial on how to define a manifold and moves it to a quarto notebooks as well.
I noticed two things this PR could also resolve
exp
it is enough to defineexp!(M, q, p, X)
theexp!(M, q, p, X, t)
falls back to this. for retract it is the other way around, one has to defineretract_method!(M, q, p, X, t)
AbstractRetractionMethod
subtype which lower level function corresponds to the high level type?Besides that this needs a careful check that the new CI runs fine and that all examples and references are correct.
The example itself was not changed much.
ToDo
@ref
s) I am not 100% sure why since I made that the same way as over on the other packages.