You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The positive responses to #9349 encouraged me to look into one obvious bug: once it prints something in red, it goes back to :normal rather than :bold printing. It seems to me that fixing this properly means that each relevant display object should maintain state as a stack, and with_output_color should push! and pop! from the stack.
However, I really don't know much about our Display infrastructure or terminals & display in general, so I'm soliciting advice/involvement from experts like @stevengj and @StefanKarpinski.
The text was updated successfully, but these errors were encountered:
ihnorton
added
io
Involving the I/O subsystem: libuv, read, write, etc.
needs decision
A decision on this change is needed
and removed
help wanted
Indicates that a maintainer wants help on an issue or pull request
labels
Dec 15, 2014
I think it is unlikely for more advanced color printing to get into Base. To note, Crayons.jl does support exactly this kind of stack: https://github.com/KristofferC/Crayons.jl#advanced-nesting-of-colors-and-styles so in the spirit of moving things out of Base, pointing to that package seems good enough for now. If we need it for our own error reporting it could be brought in later in some sort of standard library style.
The positive responses to #9349 encouraged me to look into one obvious bug: once it prints something in red, it goes back to
:normal
rather than:bold
printing. It seems to me that fixing this properly means that each relevant display object should maintain state as a stack, andwith_output_color
shouldpush!
andpop!
from the stack.However, I really don't know much about our Display infrastructure or terminals & display in general, so I'm soliciting advice/involvement from experts like @stevengj and @StefanKarpinski.
The text was updated successfully, but these errors were encountered: