-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code warntype should show print the unstable SSA values in red/yellow #54028
Comments
addressing JuliaLang#54028
I don't know the consequences of directly interpolating expression here but here is the first attempt at it. Any guiding information on coverage of IR statements in code changes made will be appreciated. |
@gbaraldi Should line 19 be highlighted too ? |
IMO, only the IR statement would have the red color, similar to how currently only |
I was checking a good first issue to start with, and I think this is solved already. Am I right? |
@joseeloren Its partially solved and need tests. Also, I have commits on my local setup. I am struggling to make time, and I don't recollect if I have it all resolved. If you don't see any commits from me by coming weekend it's all yours. In case you end up taking this up, the existing code is good enough for adding tests directly (I think it doesn't cover few node types yet and that can be next PR or next set of commits after passing tests for commits made so far). |
… tests for unstable SSA values useref values in red
Hey there, I would like to take this issue |
Hi @KeshavSingh2703 I was working on this on #55435 , but I am not getting response. |
The current status includes partial tests and coverage for specific cases, though it might still need further refinements and checks for completeness. |
If you have some code like
It would be useful if
%17
was printed in red�The text was updated successfully, but these errors were encountered: