Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in thread-safety correctness of detecting compilation finished #53432

Closed
vtjnash opened this issue Feb 22, 2024 · 1 comment
Closed

regression in thread-safety correctness of detecting compilation finished #53432

vtjnash opened this issue Feb 22, 2024 · 1 comment
Labels
compiler:inference Type inference multithreading Base.Threads and related functionality regression Regression in behavior compared to a previous version

Comments

@vtjnash
Copy link
Member

vtjnash commented Feb 22, 2024

The ci_has_abi uses monotonic loads, so #53219 introduced a data-race here. I think it needs an :acquire on one or move of these to fix that, so that it must observe this being set. And also needs to switch the order of the checks, so that it correctly pairs with the release store.

Originally posted by @vtjnash in #53219 (comment)

Posting as an issue since the PR is already merged, so this doesn't get lost
@vtjnash vtjnash changed the title regression in thread-safety correctness regression in thread-safety correctness of detecting compilation finished Feb 22, 2024
@vtjnash vtjnash added regression Regression in behavior compared to a previous version multithreading Base.Threads and related functionality compiler:inference Type inference labels Feb 22, 2024
@gbaraldi gbaraldi mentioned this issue Feb 27, 2024
Closed
@vtjnash
Copy link
Member Author

vtjnash commented Jan 3, 2025

Fixed in #56880 which added acquire annotation in ci_has_abi and fixed the order of statements

@vtjnash vtjnash closed this as completed Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler:inference Type inference multithreading Base.Threads and related functionality regression Regression in behavior compared to a previous version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vtjnash