Skip to content

Base.Broadcast.promote_containertype improvements #21534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TotalVerb opened this issue Apr 24, 2017 · 1 comment
Open

Base.Broadcast.promote_containertype improvements #21534

TotalVerb opened this issue Apr 24, 2017 · 1 comment
Labels
broadcast Applying a function over a collection collections Data structures holding multiple items, e.g. sets

Comments

@TotalVerb
Copy link
Contributor

As has been noted in the past, and again here, adding new containertypes to broadcast tends to involve adding many new methods. For example, in practice methods seem to come in pairs, one for each argument order. (see e.g. https://github.com/davidanthoff/DataValues.jl/pull/9/files#r113047389)

Perhaps we can borrow some techniques from number type promotion (e.g. the relationship between promote_type and promote_rule) to cut down on the number of methods needed.

cc @Sacha0, @pabloferz

@Sacha0
Copy link
Member

Sacha0 commented Apr 24, 2017

Ref. #20007 (comment). Best!

@ararslan ararslan added collections Data structures holding multiple items, e.g. sets broadcast Applying a function over a collection labels Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broadcast Applying a function over a collection collections Data structures holding multiple items, e.g. sets
Projects
None yet
Development

No branches or pull requests

3 participants