Skip to content

Commit f98decc

Browse files
committed
Restore building sys.dll on Windows, but switch default value
for --precompiled option to only load it if explicitly requested since backtraces are still a problem with llvm 3.3
1 parent c415826 commit f98decc

File tree

3 files changed

+5
-19
lines changed

3 files changed

+5
-19
lines changed

Make.inc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -384,12 +384,7 @@ endif
384384

385385

386386
# if not absolute, then relative to the directory of the julia executable
387-
# on windows, use .ji by default
388-
ifeq ($(OS),WINNT)
389-
JCPPFLAGS += "-DJL_SYSTEM_IMAGE_PATH=\"$(build_private_libdir_rel)/sys.ji\""
390-
else
391387
JCPPFLAGS += "-DJL_SYSTEM_IMAGE_PATH=\"$(build_private_libdir_rel)/sys.$(SHLIB_EXT)\""
392-
endif
393388

394389
# On Windows, we want shared library files to end up in $(build_bindir), instead of $(build_libdir)
395390
ifeq ($(OS),WINNT)

Makefile

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -182,11 +182,6 @@ $(build_private_libdir)/inference.o: $(build_private_libdir)/inference0.$(SHLIB_
182182
$(call spawn,$(JULIA_EXECUTABLE)) -C $(JULIA_CPU_TARGET) --output-o $(call cygpath_w,$(build_private_libdir)/inference.o) -f \
183183
-J $(call cygpath_w,$(build_private_libdir)/inference0.$(SHLIB_EXT)) coreimg.jl)
184184

185-
# on windows, also generate a .ji file so we can delete the .dll
186-
ifeq ($(OS),WINNT)
187-
JULIA_SYSIMG_BUILD_FLAGS += --output-ji $(call cygpath_w,$(build_private_libdir)/sys.ji)
188-
endif
189-
190185
COMMA:=,
191186
$(build_private_libdir)/sys.o: VERSION $(BASE_SRCS) $(build_docdir)/helpdb.jl $(build_private_libdir)/inference.$(SHLIB_EXT)
192187
@$(call PRINT_JULIA, cd base && \
@@ -363,15 +358,9 @@ else ifeq ($(OS), Linux)
363358
endif
364359

365360
# Overwrite JL_SYSTEM_IMAGE_PATH in julia library
366-
ifeq ($(OS),WINNT)
367-
for julia in $(DESTDIR)$(private_libdir)/libjulia*.$(SHLIB_EXT) ; do \
368-
$(call spawn,$(build_bindir)/stringreplace $$(strings -t x - $$julia | grep "sys.ji$$" | awk '{print $$1;}' ) "$(private_libdir_rel)/sys.ji" 256 $(call cygpath_w,$$julia)); \
369-
done
370-
else
371361
for julia in $(DESTDIR)$(private_libdir)/libjulia*.$(SHLIB_EXT) ; do \
372362
$(call spawn,$(build_bindir)/stringreplace $$(strings -t x - $$julia | grep "sys.$(SHLIB_EXT)$$" | awk '{print $$1;}' ) "$(private_libdir_rel)/sys.$(SHLIB_EXT)" 256 $(call cygpath_w,$$julia)); \
373363
done
374-
endif
375364
endif
376365

377366
mkdir -p $(DESTDIR)$(sysconfdir)
@@ -417,9 +406,6 @@ ifeq ($(JULIA_CPU_TARGET), native)
417406
endif
418407

419408
ifeq ($(OS), WINNT)
420-
# If we are running on windows, also delete sys.dll until we switch to llvm3.5+
421-
-rm -f $(DESTDIR)$(private_libdir)/sys.$(SHLIB_EXT)
422-
423409
[ ! -d dist-extras ] || ( cd dist-extras && \
424410
cp 7z.exe 7z.dll libexpat-1.dll zlib1.dll libgfortran-3.dll libquadmath-0.dll libstdc++-6.dll libgcc_s_s*-1.dll libssp-0.dll $(bindir) && \
425411
mkdir $(DESTDIR)$(prefix)/Git && \

src/init.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,12 @@ jl_options_t jl_options = { 0, // quiet
111111
JL_OPTIONS_FAST_MATH_DEFAULT,
112112
0, // worker
113113
JL_OPTIONS_HANDLE_SIGNALS_ON,
114+
#ifdef _OS_WINDOWS_
115+
// TODO remove this when using LLVM 3.5+
116+
JL_OPTIONS_USE_PRECOMPILED_NO,
117+
#else
114118
JL_OPTIONS_USE_PRECOMPILED_YES,
119+
#endif
115120
NULL, // bindto
116121
NULL, // outputbc
117122
NULL, // outputo

0 commit comments

Comments
 (0)