Skip to content

Commit f115695

Browse files
committed
Pkg: fix my buggy Cmd interpolation
Backticks quote strings that contain a space, so by adding " --inline=no" I broke `Pkg.test(pkg, coverage=true)`
1 parent 2bb647a commit f115695

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

base/pkg/entry.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ function test!(pkg::AbstractString, errs::Vector{AbstractString}, notests::Vecto
690690
cd(dirname(test_path)) do
691691
try
692692
color = Base.have_color? "--color=yes" : "--color=no"
693-
codecov = coverage? "--code-coverage=user --inline=no" : "--code-coverage=none"
693+
codecov = coverage? ["--code-coverage=user", "--inline=no"] : ["--code-coverage=none"]
694694
run(`$JULIA_HOME/julia --check-bounds=yes $codecov $color $test_path`)
695695
info("$pkg tests passed")
696696
catch err

0 commit comments

Comments
 (0)