A few missing tests for cholesky (#19396)

* Missing tests for cholfact

* Error throwing tests for up/downdate

Author: kshyatt

test/linalg/cholesky.jl

@@ -66,10 +66,24 @@ for eltya in (Float32, Float64, Complex64, Complex128, BigFloat, Int)
         capds = cholfact(apds)
         @test inv(capds)*apds ≈ eye(n)
         @test abs((det(capds) - det(apd))/det(capds)) <= ε*κ*n
+        if eltya <: BlasReal
+            capds = cholfact!(copy(apds))
+            @test inv(capds)*apds ≈ eye(n)
+            @test abs((det(capds) - det(apd))/det(capds)) <= ε*κ*n
+        end
     else
         capdh = cholfact(apdh)
         @test inv(capdh)*apdh ≈ eye(n)
         @test abs((det(capdh) - det(apd))/det(capdh)) <= ε*κ*n
+        capdh = cholfact!(copy(apdh))
+        @test inv(capdh)*apdh ≈ eye(n)
+        @test abs((det(capdh) - det(apd))/det(capdh)) <= ε*κ*n
+        capdh = cholfact!(copy(apd))
+        @test inv(capdh)*apdh ≈ eye(n)
+        @test abs((det(capdh) - det(apd))/det(capdh)) <= ε*κ*n
+        capdh = cholfact!(copy(apd), :L)
+        @test inv(capdh)*apdh ≈ eye(n)
+        @test abs((det(capdh) - det(apd))/det(capdh)) <= ε*κ*n
     end
 
     # test chol of 2x2 Strang matrix
@@ -125,6 +139,7 @@ for eltya in (Float32, Float64, Complex64, Complex128, BigFloat, Int)
         @test size(cpapd) == size(apd)
         @test full(copy(cpapd)) ≈ apd
         @test det(cpapd) ≈ det(apd)
+        @test logdet(cpapd) ≈ logdet(apd)
         @test cpapd[:P]*cpapd[:L]*cpapd[:U]*cpapd[:P]' ≈ apd
     end
 
@@ -203,7 +218,9 @@ let A = complex(randn(10,5), randn(10, 5)), v = complex(randn(5), randn(5))
         F = cholfact(AcA, uplo)
         G = cholfact(BcB, uplo)
         @test LinAlg.lowrankupdate(F, v)[uplo] ≈ G[uplo]
+        @test_throws DimensionMismatch LinAlg.lowrankupdate(F, ones(eltype(v), length(v)+1))
         @test LinAlg.lowrankdowndate(G, v)[uplo] ≈ F[uplo]
+        @test_throws DimensionMismatch LinAlg.lowrankdowndate(G, ones(eltype(v), length(v)+1))
     end
 end
 
@@ -245,3 +262,6 @@ end
 @test_throws ArgumentError Base.LinAlg.cholfact!(randn(5,5),:U,Val{false})
 @test_throws ArgumentError Base.LinAlg.cholfact!(randn(5,5),:U,Val{true})
 @test_throws ArgumentError cholfact(randn(5,5),:U,Val{false})
+
+# Fail for non-BLAS element types
+@test_throws ArgumentError cholfact!(Hermitian(rand(Float16, 5,5)), Val{true})