remove error when calling fieldtype on a Module (#34804)

KristofferC · KristofferC · commit b5c2cbea4469 · 2020-04-11T19:32:13.000+02:00
diff --git a/src/builtins.c b/src/builtins.c
@@ -885,8 +885,6 @@ JL_CALLABLE(jl_f_fieldtype)
     }
     JL_NARGS(fieldtype, 2, 2);
     jl_datatype_t *st = (jl_datatype_t*)args[0];
-    if (st == jl_module_type)
-        jl_error("cannot assign variables in other modules");
     return get_fieldtype(args[0], args[1], 1);
 }
 
diff --git a/test/misc.jl b/test/misc.jl
@@ -804,3 +804,7 @@ end
 
     GC.safepoint()
 end
+
+@testset "fieldtypes Module" begin
+    @test fieldtypes(Module) isa Tuple
+end

Original file line number	Diff line number	Diff line change
`@@ -885,8 +885,6 @@ JL_CALLABLE(jl_f_fieldtype)`
`885`	`885`	`}`
`886`	`886`	`JL_NARGS(fieldtype, 2, 2);`
`887`	`887`	`jl_datatype_t st = (jl_datatype_t)args[0];`
`888`		`- if (st == jl_module_type)`
`889`		`- jl_error("cannot assign variables in other modules");`
`890`	`888`	`return get_fieldtype(args[0], args[1], 1);`
`891`	`889`	`}`
`892`	`890`