Skip to content

Commit ada8b06

Browse files
committed
restrict isless and cmp to vectors
also implement it for row vectors
1 parent 63487e3 commit ada8b06

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

base/abstractarray.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1548,7 +1548,7 @@ function isequal(A::AbstractArray, B::AbstractArray)
15481548
return true
15491549
end
15501550

1551-
function cmp(A::AbstractArray, B::AbstractArray)
1551+
function cmp(A::AbstractVector, B::AbstractVector)
15521552
for (a, b) in zip(A, B)
15531553
if !isequal(a, b)
15541554
return isless(a, b) ? -1 : 1
@@ -1557,7 +1557,7 @@ function cmp(A::AbstractArray, B::AbstractArray)
15571557
return cmp(length(A), length(B))
15581558
end
15591559

1560-
isless(A::AbstractArray, B::AbstractArray) = cmp(A, B) < 0
1560+
isless(A::AbstractVector, B::AbstractVector) = cmp(A, B) < 0
15611561

15621562
function (==)(A::AbstractArray, B::AbstractArray)
15631563
if axes(A) != axes(B)

base/linalg/adjtrans.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,8 @@ similar(A::AdjOrTrans, ::Type{T}, dims::Dims{N}) where {T,N} = similar(A.parent,
116116
parent(A::AdjOrTrans) = A.parent
117117
vec(v::AdjOrTransAbsVec) = v.parent
118118

119+
cmp(A::AdjOrTransAbsVec, B::AdjOrTransAbsVec) = cmp(parent(A), parent(B))
120+
isless(A::AdjOrTransAbsVec, B::AdjOrTransAbsVec) = isless(parent(A), parent(B))
119121

120122
### concatenation
121123
# preserve Adjoint/Transpose wrapper around vectors

0 commit comments

Comments
 (0)