Skip to content

Commit 94adc99

Browse files
omustkelman
authored andcommitted
Deprecate @vectorize_1arg for Dates functions within scope of Dates module (#18456)
* Deprecate vectorize_1arg for Dates within module Otherwise there are issues with functions being independently defined within multiple modules: ```julia julia> using Base.Dates julia> unix2datetime(0) WARNING: both Dates and Base export "unix2datetime"; uses of it in module Main must be qualified ERROR: UndefVarError: unix2datetime not defined ``` * Slight adjustment for readability
1 parent fb503a0 commit 94adc99

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

base/deprecated.jl

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -926,14 +926,17 @@ for f in (
926926
:erfinc, :erfcinv, # base/special/erf.jl
927927
:trunc, :floor, :ceil, :round, # base/floatfuncs.jl
928928
:rad2deg, :deg2rad, :exponent, :significand, # base/math.jl
929-
:unix2datetime, :rata2datetime, :julian2datetime, # base/dates/conversions.jl
930929
:sind, :cosd, :tand, :asind, :acosd, :atand, :asecd, :acscd, :acotd, # base/special/trig.jl
931930
)
932931
@eval @dep_vectorize_1arg Real $f
933932
end
934933
# base/complex.jl
935934
@dep_vectorize_1arg Complex round
936935
@dep_vectorize_1arg Complex float
936+
# base/dates/*.jl
937+
for f in (:unix2datetime, :rata2datetime, :julian2datetime) # base/dates/conversions.jl
938+
eval(Dates, :(Base.@dep_vectorize_1arg Real $f))
939+
end
937940
for f in (
938941
# base/dates/accessors.jl
939942
:year, :month, :day, :week, :dayofmonth, :yearmonth, :monthday, :yearmonthday,
@@ -946,15 +949,15 @@ for f in (
946949
:daysofweekinmonth, :monthname, :monthabbr, :daysinmonth,
947950
:isleapyear, :dayofyear, :daysinyear, :quarterofyear, :dayofquarter,
948951
)
949-
@eval @dep_vectorize_1arg Dates.TimeType $f
952+
eval(Dates, :(Base.@dep_vectorize_1arg Dates.TimeType $f))
950953
end
951954
for f in (
952955
:hour, :minute, :second, :millisecond, # base/dates/accessors.jl
953956
:Date, :datetime2unix, :datetime2rata, :datetime2julian, # base/dates/conversions.jl
954957
)
955-
@eval @dep_vectorize_1arg Dates.DateTime $f
958+
eval(Dates, :(Base.@dep_vectorize_1arg Dates.DateTime $f))
956959
end
957-
@dep_vectorize_1arg Dates.Date Datetime # base/dates/conversions.jl
960+
eval(Dates, :(Base.@dep_vectorize_1arg Dates.Date Datetime)) # base/dates/conversions.jl
958961

959962
# Deprecate @vectorize_2arg-vectorized functions from...
960963
for f in (

0 commit comments

Comments
 (0)