Skip to content

Commit 79c492d

Browse files
committed
Add NEWS and remove FIXME
The FIXME was about a behavior which should not be supported.
1 parent 53b41b1 commit 79c492d

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

NEWS.md

+5
Original file line numberDiff line numberDiff line change
@@ -702,6 +702,10 @@ Deprecated or removed
702702
* `cumsum`, `cumprod`, `accumulate`, and their mutating versions now require a `dim`
703703
argument instead of defaulting to using the first dimension ([#24684]).
704704

705+
* `search` and `rsearch` have been deprecated in favor of `findfirst`/`findnext` and
706+
`findlast`/`findprev` respectively, in combination with the new `equalto` and `occursin`
707+
predicates for some methods ([#24673]).
708+
705709
Command-line option changes
706710
---------------------------
707711

@@ -1666,3 +1670,4 @@ Command-line option changes
16661670
[#24320]: https://github.com/JuliaLang/julia/issues/24320
16671671
[#24396]: https://github.com/JuliaLang/julia/issues/24396
16681672
[#24413]: https://github.com/JuliaLang/julia/issues/24413
1673+
[#24684]: https://github.com/JuliaLang/julia/issues/24684

base/deprecated.jl

-2
Original file line numberDiff line numberDiff line change
@@ -2178,7 +2178,6 @@ end
21782178
@deprecate search(s::AbstractString, r::Regex) findfirst(r, s)
21792179
@deprecate search(s::AbstractString, c::Char, i::Integer) findnext(equalto(c), s, i)
21802180
@deprecate search(s::AbstractString, c::Char) findfirst(equalto(c), s)
2181-
# FIXME: no replacement to search for a multibyte char in a ByteArray
21822181
@deprecate search(a::ByteArray, b::Union{Int8,UInt8}, i::Integer) findnext(equalto(b), a, i)
21832182
@deprecate search(a::ByteArray, b::Union{Int8,UInt8}) findfirst(equalto(b), a)
21842183
@deprecate search(a::String, b::Union{Int8,UInt8}, i::Integer) findnext(equalto(b), Vector{UInt8}(a), i)
@@ -2207,7 +2206,6 @@ end
22072206
@deprecate rsearch(s::AbstractString, r::Regex) findlast(r, s)
22082207
@deprecate rsearch(s::AbstractString, c::Char, i::Integer) findprev(equalto(c), s, i)
22092208
@deprecate rsearch(s::AbstractString, c::Char) findlast(equalto(c), s)
2210-
# FIXME: no replacement to search for a multibyte char in a ByteArray
22112209
@deprecate rsearch(a::Union{String,ByteArray}, b::Union{Int8,UInt8}, i::Integer = endof(a)) findprev(equalto(b), a, i)
22122210
@deprecate rsearch(a::String, b::Union{Int8,UInt8}, i::Integer = endof(a)) findprev(equalto(Char(b)), a, i)
22132211
@deprecate rsearch(a::ByteArray, b::Char, i::Integer = endof(a)) findprev(equalto(UInt8(b)), a, i)

0 commit comments

Comments
 (0)