Merge pull request #18888 from JuliaLang/tb/uncached_reflection

Don't cache inference results if not optimizing.

Author: maleadt

base/reflection.jl

@@ -583,7 +583,7 @@ function code_typed(f::ANY, types::ANY=Tuple; optimize=true)
     asts = []
     for x in _methods(f, types, -1)
         meth = func_for_method_checked(x[3], types)
-        (code, ty) = Core.Inference.typeinf_code(meth, x[1], x[2], optimize, !optimize)
+        (code, ty) = Core.Inference.typeinf_code(meth, x[1], x[2], optimize, optimize)
         code === nothing && error("inference not successful") # Inference disabled?
         push!(asts, uncompressed_ast(meth, code) => ty)
     end

test/reflection.jl

@@ -573,3 +573,20 @@ end
 @test counter18434 == 1
 @which get_A18434()(1, y=2)
 @test counter18434 == 2
+
+# PR #18888: code_typed shouldn't cache if not optimizing
+let
+    f18888() = return nothing
+    m = first(methods(f18888, Tuple{}))
+    @test m.specializations == nothing
+    ft = typeof(f18888)
+
+    code_typed(f18888, Tuple{}; optimize=false)
+    @test m.specializations != nothing  # uncached, but creates the specializations entry
+    code = Core.Inference.code_for_method(m, Tuple{ft}, Core.svec(), true)
+    @test !isdefined(code, :inferred)
+
+    code_typed(f18888, Tuple{}; optimize=true)
+    code = Core.Inference.code_for_method(m, Tuple{ft}, Core.svec(), true)
+    @test isdefined(code, :inferred)
+end