Skip to content

Commit 5989eaf

Browse files
authored
Merge pull request #19671 from stevengj/disambig_q
remove method ambiguity with *(y::Number, x::Bool) in test
2 parents 76a9180 + 89db843 commit 5989eaf

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/linalg/generic.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ Base.isfinite(q::Quaternion) = isfinite(q.s) & isfinite(q.v1) & isfinite(q.v2) &
2525
q.s*w.v2 - q.v1*w.v3 + q.v2*w.s + q.v3*w.v1,
2626
q.s*w.v3 + q.v1*w.v2 - q.v2*w.v1 + q.v3*w.s)
2727
(*)(q::Quaternion, r::Real) = Quaternion(q.s*r, q.v1*r, q.v2*r, q.v3*r)
28+
(*)(q::Quaternion, b::Bool) = b * q # remove method ambiguity
2829
(/)(q::Quaternion, w::Quaternion) = q * conj(w) * (1.0 / abs2(w))
2930
(\)(q::Quaternion, w::Quaternion) = conj(q) * w * (1.0 / abs2(q))
3031

0 commit comments

Comments
 (0)