Merge pull request #18720 from JuliaLang/jb/fix10981

fix #10981, splatting very long argument lists

Author: JeffBezanson

src/alloc.c

@@ -1006,7 +1006,12 @@ void jl_compute_field_offsets(jl_datatype_t *st)
     uint64_t max_size = max_offset >> 1;
 
     uint32_t nfields = jl_svec_len(st->types);
-    jl_fielddesc32_t* desc = (jl_fielddesc32_t*) alloca(nfields * sizeof(jl_fielddesc32_t));
+    size_t descsz = nfields * sizeof(jl_fielddesc32_t);
+    jl_fielddesc32_t *desc;
+    if (descsz < jl_page_size)
+        desc = (jl_fielddesc32_t*)alloca(descsz);
+    else
+        desc = (jl_fielddesc32_t*)malloc(descsz);
     int haspadding = 0;
     assert(st->name == jl_tuple_typename ||
            st == jl_sym_type ||
@@ -1020,7 +1025,7 @@ void jl_compute_field_offsets(jl_datatype_t *st)
             fsz = jl_datatype_size(ty);
             // Should never happen
             if (__unlikely(fsz > max_size))
-                jl_throw(jl_overflow_exception);
+                goto throw_ovf;
             al = ((jl_datatype_t*)ty)->layout->alignment;
             desc[i].isptr = 0;
             if (((jl_datatype_t*)ty)->layout->haspadding)
@@ -1046,7 +1051,7 @@ void jl_compute_field_offsets(jl_datatype_t *st)
         desc[i].offset = sz;
         desc[i].size = fsz;
         if (__unlikely(max_offset - sz < fsz))
-            jl_throw(jl_overflow_exception);
+            goto throw_ovf;
         sz += fsz;
     }
     if (homogeneous && lastty!=NULL && jl_is_tuple_type(st)) {
@@ -1060,6 +1065,11 @@ void jl_compute_field_offsets(jl_datatype_t *st)
     if (st->size > sz)
         haspadding = 1;
     st->layout = jl_get_layout(nfields, alignm, haspadding, desc);
+    if (descsz >= jl_page_size) free(desc);
+    return;
+ throw_ovf:
+    if (descsz >= jl_page_size) free(desc);
+    jl_throw(jl_overflow_exception);
 }
 
 extern int jl_boot_file_loaded;

test/core.jl

@@ -4600,3 +4600,13 @@ gVararg(a::fVararg(Int)) = length(a)
 catch e
     (e::ErrorException).msg
 end == "generated function body is not pure. this likely means it contains a closure or comprehension."
+
+# issue #10981, long argument lists
+let a = fill(["sdf"], 2*10^6), temp_vcat(x...) = vcat(x...)
+    # we introduce a new function `temp_vcat` to make sure there is no existing
+    # method cache match, leading to a path that allocates a large tuple type.
+    b = temp_vcat(a...)
+    @test isa(b, Vector{String})
+    @test length(b) == 2*10^6
+    @test b[1] == b[end] == "sdf"
+end