Shred payload when non-EAUTH errors occur

Author: omus

stdlib/LibGit2/src/LibGit2.jl

@@ -294,6 +294,8 @@ function fetch(repo::GitRepo; remote::AbstractString="origin",
     catch err
         if isa(err, GitError) && err.code == Error.EAUTH
             reject(cred_payload)
+        else
+            Base.shred!(cred_payload)
         end
         rethrow()
     finally
@@ -350,6 +352,8 @@ function push(repo::GitRepo; remote::AbstractString="origin",
     catch err
         if isa(err, GitError) && err.code == Error.EAUTH
             reject(cred_payload)
+        else
+            Base.shred!(cred_payload)
         end
         rethrow()
     finally
@@ -584,6 +588,8 @@ function clone(repo_url::AbstractString, repo_path::AbstractString;
         catch err
             if isa(err, GitError) && err.code == Error.EAUTH
                 reject(cred_payload)
+            else
+                Base.shred!(cred_payload)
             end
             rethrow()
         end

stdlib/LibGit2/src/types.jl

@@ -1361,6 +1361,12 @@ end
 
 CredentialPayload(p::CredentialPayload) = p
 
+function Base.shred!(p::CredentialPayload)
+    # Note: Avoid shredding the `explicit` or `cache` fields as these are just references
+    # and it is not our responsibility to shred them.
+    p.credential !== nothing && Base.shred!(p.credential)
+    p.credential = nothing
+end
 
 """
     reset!(payload, [config]) -> CredentialPayload