Skip to content

Commit 15ee73a

Browse files
fredrikekreandreasnoack
authored andcommitted
add missing method for eigvecs(A::HermOrSym) (#22453)
1 parent 2de5dab commit 15ee73a

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

base/linalg/symmetric.jl

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -480,6 +480,8 @@ eigvals!(A::HermOrSym{T,S}, B::HermOrSym{T,S}) where {T<:BlasReal,S<:StridedMatr
480480
eigvals!(A::Hermitian{T,S}, B::Hermitian{T,S}) where {T<:BlasComplex,S<:StridedMatrix} =
481481
LAPACK.sygvd!(1, 'N', A.uplo, A.data, B.uplo == A.uplo ? B.data : B.data')[1]
482482

483+
eigvecs(A::HermOrSym) = eigvecs(eigfact(A))
484+
483485
function svdvals!(A::RealHermSymComplexHerm)
484486
vals = eigvals!(A)
485487
for i = 1:length(vals)

test/linalg/symmetric.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ end
129129
@test eigvals(Hermitian(asym), 1:2) d[1:2]
130130
@test eigvals(Hermitian(asym), d[1] - 1, (d[2] + d[3])/2) d[1:2]
131131
@test full(eigfact(asym)) asym
132+
@test eigvecs(Hermitian(asym)) eigvecs(asym)
132133

133134
# relation to svdvals
134135
@test sum(sort(abs.(eigvals(Hermitian(asym))))) == sum(sort(svdvals(Hermitian(asym))))

0 commit comments

Comments
 (0)