Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heartbeat initialization #1144

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

halleysfifthinc
Copy link
Contributor

Fixes a bad rebase in #1135; noticed after merge
here.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 10.21%. Comparing base (32d030c) to head (1550d05).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/init.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1144   +/-   ##
=======================================
  Coverage   10.21%   10.21%           
=======================================
  Files          14       14           
  Lines         822      822           
=======================================
  Hits           84       84           
  Misses        738      738           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JamesWrigley JamesWrigley merged commit 855eba2 into JuliaLang:master Jan 31, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants