Add Aqua to the test suite #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libdl is now not used, and Test is a proper test dependency instead of a package dependency.
Turns out we commit type piracy on `Base.display()`, so the piracy test is disabled for now.
Since that's the minimum supported version now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
==========================================
- Coverage 10.48% 10.21% -0.27%
==========================================
Files 14 14
Lines 820 822 +2
==========================================
- Hits 86 84 -2
- Misses 734 738 +4 ☔ View full report in Codecov by Sentry. |
|
(I'll go ahead and merge this, we can figure out the pirated method later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we commit type piracy on
Base.display(), so the piracy test is disabled for now until we figure out if it's needed. @stevengj, do you know if it's needed? AFAICT the method isn't called anywhere in the code base and it's not documented either.Also removed some unnecessary dependencies in 4885721.