Codegen error when running on newer cimplot

[JamesWrigley]

So I'm shaving all the yaks to update the ImPlot/ImGui/ImNodes wrappers, and I'm running into this error when running the generator on the header for cimplot:

julia> include("generator.jl")
[ Info: processing x86_64-linux-gnu
[ Info: Found dependent header: /home/james/.julia/artifacts/fe48f0b2aafb29660aa25ab0e55249169fabee58/include/cimgui.h
[ Info: Parsing headers...
[ Info: Processing header: /home/james/.julia/artifacts/fe48f0b2aafb29660aa25ab0e55249169fabee58/include/cimplot.h
[ Info: Building the DAG...
┌ Warning: [CollectDependentSystemNode]: found symbols in the system headers: [:tm, :__time_t, :time_t]
└ @ Clang.Generators ~/git/Clang/src/generator/passes.jl:95
[ Info: Emit Julia expressions...
ERROR: LoadError: AssertionError: is_jl_pointer(jlty)
Stacktrace:
 [1] emit!(dag::ExprDAG, node::ExprNode{Clang.Generators.StructMutualRef, Clang.CLStructDecl}, options::Dict{String, Any}; args::@Kwargs{idx::Int64})
   @ Clang.Generators ~/git/Clang/src/generator/codegen.jl:546
 [2] (::Codegen)(dag::ExprDAG, options::Dict{String, Any})
   @ Clang.Generators ~/git/Clang/src/generator/passes.jl:734
 [3] build!(ctx::Context, stage::Clang.Generators.BuildStage)
   @ Clang.Generators ~/git/Clang/src/generator/context.jl:176
 [4] build!
   @ ~/git/Clang/src/generator/context.jl:167 [inlined]
 [5] top-level scope
   @ ~/git/LibCImGui/gen/generator.jl:31
 [6] include(fname::String)
   @ Base.MainInclude ./client.jl:489
 [7] top-level scope
   @ REPL[15]:1
in expression starting at /home/james/git/LibCImGui/gen/generator.jl:20

To reproduce:

• Build a JLL from this: https://github.com/JamesWrigley/Yggdrasil/blob/cimgui-pack/C/CImGuiPack/build_tarballs.jl

  julia build_tarballs.jl --deploy=local
  

  That'll build versions of cimgui/cimplot/cimnodes that should all work with v1.89.4 (last release I could find with builds for all those packages).
• Activate the gen/ environment in LibCImGui.jl, and make sure to dev CImGuiPack_jll so it picks up the locally built version.
• Run include("gen/generator.jl"). Optional: only include the cimplot header here to narrow it down: https://github.com/JuliaImGui/LibCImGui.jl/blob/master/gen/generator.jl#L22

For convenience, here's the header it's running on: https://gist.github.com/JamesWrigley/4d1d071b8532b359df112428eb4062d3
By trial and error I found that the error is coming from this line in ImPlotPlot, commenting that out fixes it: https://gist.github.com/JamesWrigley/4d1d071b8532b359df112428eb4062d3#file-cimplot-h-L647
Even stranger, if I leave that Axes declaration in but change it to a single ImPlotAxis member instead of an array, or I try commenting out this line instead in ImPlotAxis it also works: https://gist.github.com/JamesWrigley/4d1d071b8532b359df112428eb4062d3#file-cimplot-h-L565
Even even stranger, commenting out other types such as on line 670 or 631 or 629 also fixes it 🤔

And this point I got totally confused and thought I should ask for help 😅 Has anyone got any ideas about what's happening here?

[JamesWrigley]

Hmm, after more investigation it seems that ImPlotPlot is being converted to a StructMutualRef by the RemoveCircularReference pass because it detects it and ImPlotAxis as being mutually referenced. Unless I'm missing something I don't think that's correct.

[JamesWrigley]

Turned out to be because of the RemoveCircularReference pass being too aggressive: #441.