Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion on creating demos for algorithms implemented in ImageBinarization.jl #73

Open
ashwani-rathee opened this issue Nov 23, 2020 · 3 comments

Comments

@ashwani-rathee
Copy link
Member

ashwani-rathee commented Nov 23, 2020

In #164,It was pointed out that even though ImageBinarization.jl has very detailed explanations in docstring.There is a need for setting up a demo page and move the explanations to the form of demos for each algorithm.

@johnnychen94
Copy link
Member

johnnychen94 commented Nov 23, 2020

A quite long time ago, I had a discussion with @zygmuntszpak on slack and I believe we have reached a consensus to move the detailed explanations as demo cards and add URL links back to the docstrings. I never made it because at that time DemoCards is at a very early stage. The main issues of the current docstrings IMO are:

  • the docstrings are too long to quickly get an idea of how an algorithm should be used,
  • latex strings are not well-formatted in REPL

I'm working on #70. It's almost done; just needs confirmation from @zygmuntszpak I'll set up DemoCards after that, and we can proceed with this.

Another issue related to this is JuliaImages/HistogramThresholding.jl#34, that we need to refactor the codes to really get useful docstrings with ?Yen. After #70, ?Yen gives nothing.

Personally, I would recommend you to try JuliaImages/HistogramThresholding.jl#34 out since that gives some real challenges to modify the codebase without breaking anything. I believe you can learn more by doing that than writing demos.

@ashwani-rathee
Copy link
Member Author

ashwani-rathee commented Nov 24, 2020

It would be really exciting to do a medium size project(refactor task is fairly long) after I am used to JuliaImages.I think for the next fortnight,I'll do some 4-5 demos and then get on with helping on refactoring JuliaImages/HistogramThresholding.jl#34

@zygmuntszpak
Copy link
Member

Thanks, Johnny and Ashwani for working on this. As Johnny stated, the vision is to move the detailed LaTeX explanations as demo cards and add and URL to the demo in the docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants