Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: config, workflow and some typos fixed #120

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

yarikoptic
Copy link
Contributor

workflow would fail whenever a new typo is introduced (or new codespell knows about some new typos).

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@yarikoptic
Copy link
Contributor Author

CI fails are on windows only and some doctest fail due to difference in 1 vs true. I do not think any of those could be triggered by changes in this PR

Copy link
Collaborator

@meggart meggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the test failures are unrelated. Thanks a lot for the PR!

@nhz2
Copy link
Member

nhz2 commented Jun 30, 2023

I think the test failures on Windows may be related to conda/conda#9903

@meggart meggart merged commit 84514cf into JuliaIO:master Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants