Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free usage should be in the first example #75

Closed
freeboson opened this issue Oct 11, 2017 · 4 comments
Closed

free usage should be in the first example #75

freeboson opened this issue Oct 11, 2017 · 4 comments

Comments

@freeboson
Copy link
Contributor

I was recently helping a colleague with his script that did some processing of XML files with this package. I was looking in all of the other places for why the memory usage was blowing up, before realizing it was due to not calling free.

I completely understand now why the memory allocated by this package cannot be garbage collected, but this is definitely an important thing to stress. It first shows up in the readme about 2/3 of the way down, but IMO it's a basic requirement for using this package. I think the very first example should make use of free.

@freeboson freeboson changed the title free usage should be in the first example free usage should be in the first example Oct 12, 2017
@bicycle1885
Copy link
Member

Just out of curiosity, why you don't choose EzXML.jl? It frees allocated memories automatically and I believe it covers all functionalities of LightXML.jl. I would like to know the reason to improve my package.

@freeboson
Copy link
Contributor Author

freeboson commented Oct 20, 2017

@bicycle1885 actually, my colleague ended up using XMLDict.jl. I would use EzXML.jl or XMLDict.jl.

@bicycle1885
Copy link
Member

Okay, thank you.

@samoconnor
Copy link

See #45

@musm musm closed this as completed in #76 May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants