Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation about using files in memory #1118

Merged
merged 4 commits into from
Sep 24, 2023
Merged

Update documentation about using files in memory #1118

merged 4 commits into from
Sep 24, 2023

Conversation

denglerchr
Copy link
Contributor

An entry in the doc and a small correction of the Drivers.Core doc-string. For recently added functionality in #552

@mkitti
Copy link
Member

mkitti commented Sep 16, 2023

Thanks. I will look this over this weekend.

@mkitti
Copy link
Member

mkitti commented Sep 19, 2023

This is mergeable.

I would like to investigate how the default was documented wrong.

Also, I would prefer the do syntax with h5open as well as using jldoctest.

Let me know if you are interested in iterating or not.

@denglerchr
Copy link
Contributor Author

Seems like the default for the Core driver has been documented like this from its creation 0eaec09#diff-eaf75d58da3a8bb4a3287bf539f3167efd5c7e8dc58c23289560013c98ac7b16
Ill changed to the do syntax for the examples

@mkitti
Copy link
Member

mkitti commented Sep 19, 2023

Right, but how did that happen. Is there a mismatch between upstream and this package?

@mkitti mkitti merged commit 703cd56 into JuliaIO:master Sep 24, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants