Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PythonCall.jl? #27

Open
Moelf opened this issue Sep 30, 2024 · 4 comments
Open

Switch to PythonCall.jl? #27

Moelf opened this issue Sep 30, 2024 · 4 comments

Comments

@Moelf
Copy link
Member

Moelf commented Sep 30, 2024

@ianna reported installing this pkg breaks a bunch of things in her environment

@oschulz
Copy link
Member

oschulz commented Sep 30, 2024

PythonCall still seems to have trouble with Julia multi-threading (well, PyCall can have too, but it seems worse with PythonCall). So I'm not sure ... question is, do we need UpROOT long-term at all, now that UnROOT is already quite mature (and with UpROOT having no writing API anyway) and now that we have a working ROOT wapper package again? Or should we just recommend that users, if UnROOT can't handle their use case yet, use Python uproot via PyCall or PythonCall directly or use the ROOT wrapper?

@ianna
Copy link
Member

ianna commented Sep 30, 2024

PythonCall still seems to have trouble with Julia multi-threading (well, PyCall can have too, but it seems worse with PythonCall). So I'm not sure ... question is, do we need UpROOT long-term at all, now that UnROOT is already quite mature (and with UpROOT having no writing API anyway) and now that we have a working ROOT wapper package again? Or should we just recommend that users, if UnROOT can't handle their use case yet, use Python uproot via PyCall or PythonCall directly or use the ROOT wrapper?

if there aren't any users, I'd suggest to remove it from Package Registrator (if such thing is possible).

@Moelf
Copy link
Member Author

Moelf commented Sep 30, 2024

if UnROOT can't handle their use case yet, use Python uproot via PyCall or PythonCall directly or use the ROOT wrapper?

I'm fine with this.

if there aren't any users, I'd suggest to remove it from Package Registrator (if such thing is possible).

can't really do that but we can make like a "stub“ release, where it doesn't do anything just make an error message. Or we can make it minimally useful .... can't be too hard

@oschulz
Copy link
Member

oschulz commented Sep 30, 2024

I'd suggest to remove it from Package Registrator (if such thing is possible).

It's not - that would also very much go against the concept of reproducible computation that Pkg gives us. :-)

But we can mention that the package is deprecated in GitHub and in the README, and - some packages have done something like that - release a new version that also prints a log info message to that effect then the package is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants