Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Base.pkgversion instead of getting a hold of Pkg. #488

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jan 27, 2025

No description provided.

Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/src/utils.jl b/src/utils.jl
index ad56d7d..4d5a127 100644
--- a/src/utils.jl
+++ b/src/utils.jl
@@ -1,11 +1,11 @@
 
-function versioninfo(io::IO=stdout)
+function versioninfo(io::IO = stdout)
     if Sys.islinux()
         println(io, "Binary dependencies:")
         for jll in [oneL0.NEO_jll, oneL0.NEO_jll.libigc_jll, oneL0.NEO_jll.gmmlib_jll,
                     SPIRV_LLVM_Translator_unified_jll, SPIRV_Tools_jll]
             name = string(jll)
-            print(io, "- $(name[1:end-4]): $(Base.pkgversion(jll))")
+            print(io, "- $(name[1:(end - 4)]): $(Base.pkgversion(jll))")
             if jll.host_platform !== nothing
                 debug = tryparse(Bool, get(jll.host_platform.tags, "debug", "false"))
                 if debug === true

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.90%. Comparing base (8a63881) to head (eb6aa33).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #488      +/-   ##
==========================================
- Coverage   81.93%   81.90%   -0.04%     
==========================================
  Files          45       45              
  Lines        2552     2547       -5     
==========================================
- Hits         2091     2086       -5     
  Misses        461      461              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maleadt maleadt merged commit fac461d into master Jan 27, 2025
2 checks passed
@maleadt maleadt deleted the tb/pkgversion branch January 27, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant