[DRAFT] Add support for noncoherent integrations #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To detect weak signals from reflected GPS L1 signals from the ocean 1ms coherent integration is not enough. We need 1000x1ms noncoherent integrations to get enough processing gain Currently not working for all signals because of code doppler correction and indexing bug
Scalar downconvert! function is extremely slow compared to SIMD vectorized downconvert! function. Its better for the program to fail with missing function rather to run extremely slowly
Some RF frontends (such as TDS-1) generates real data at IF instead of complex baseband signal. Previously this is handled by the fallback downconvert! function, but that is extremely slow because it doesn't use SIMD.
Vector type is not compatible with SubArray type, use AbstractVector instead
|
Closing this PR, its too messy to upstream directly I'm currently splitting this huge messy PR into multiple smaller self-contained PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request added support for noncoherent integration for
acquirefunction.Now
acquirefunction have new keyword arguments:noncoherent_integration_round: How many noncoherent integration rounds, default is 1coherent_integration_length: Length of single coherent integration in seconds. This is API breaking, previously coherent integration length is defined by the length of the samples passed into the function. I found it to be a bit unintuitivecompensate_doppler_code: Apply doppler compensation to try to compensate code drift caused by doppler effect, some reference on the code drift problem: https://enac.hal.science/hal-00937060/document. It can take these values::disabled,:positive, which is the default, and:negativeThis will close #10
Some code cleanup is still necessary before we can merge it with upstream