New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks in the paper should be done using benchmarking packages #80

Closed

felixcremer opened this issue May 7, 2024 · 1 comment

Assignees

Contributor

felixcremer commented May 7, 2024 •

edited

Loading

Why are you using the now() - prevtime method for benchmarking and are not using BenchmarkTools and timeit in python?

In the current setup of the julia benchmarks the first compilation time is included in the first run.

openjournals/joss-reviews#6464

Datseris assigned JanJereczek

Member

Datseris commented May 7, 2024

oh yeah, that's bad. That's really bad.

JanJereczek mentioned this issue

Addressing the reviews for JOSS submission #83

Merged

Datseris closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment